Skip to content

Simplify error for := under with=FALSE #6834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ben-schwen merged 3 commits into from
Mar 12, 2025
Merged

Simplify error for := under with=FALSE #6834

ben-schwen merged 3 commits into from
Mar 12, 2025

Conversation

@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Feb 23, 2025

No description provided.

This was referenced Feb 23, 2025
Merged
Merged
@MichaelChirico Graphite App
Copy link
Member Author

MichaelChirico commented Feb 23, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MichaelChirico MichaelChirico mentioned this pull request Feb 23, 2025
Merged
@MichaelChirico MichaelChirico changed the title Simplify error for !with + := Simplify error for := under with=FALSE Feb 23, 2025
@codecov
Copy link

codecov bot commented Feb 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (bdd7e2d) to head (8f9554b).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6834      +/-   ##
==========================================
- Coverage   98.59%   98.59%   -0.01%     
==========================================
  Files          79       79              
  Lines       14661    14660       -1     
==========================================
- Hits        14455    14454       -1     
  Misses        206      206

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Feb 23, 2025 •
edited
Loading

Comparison Plot

Generated via commit 8f9554b

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 35 seconds
Installing different package versions 8 minutes and 28 seconds
Running and plotting the test cases 2 minutes and 23 seconds

@MichaelChirico MichaelChirico marked this pull request as ready for review February 23, 2025 07:17
@MichaelChirico MichaelChirico mentioned this pull request Feb 25, 2025
Merged
ben-schwen
ben-schwen reviewed Mar 8, 2025
View reviewed changes
MichaelChirico
MichaelChirico commented Mar 10, 2025
View reviewed changes
Base automatically changed from depr-inplace to master March 10, 2025 19:56
@ben-schwen ben-schwen merged commit fe8b3b1 into master Mar 12, 2025
12 checks passed
@ben-schwen ben-schwen deleted the depr-withset branch March 12, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ben-schwen ben-schwen ben-schwen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaelChirico @ben-schwen